[wp-trac] [WordPress Trac] #35032: Shiny plugin updates fails if slug has special characters

WordPress Trac noreply at wordpress.org
Sat Dec 12 16:45:46 UTC 2015


#35032: Shiny plugin updates fails if slug has special characters
-------------------------------------+------------------------------
 Reporter:  khag7                    |       Owner:  adamsilverstein
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Upgrade/Install          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------------------

Comment (by khag7):

 @adamsilverstein I'll look into this ASAP and test against some oddball
 plugin slugs.

 I think moving away from using the slug is a good idea. The slug isn't
 even generated by the WP core, its returned from an API. And if you have
 3rd party plugins from different update providers (Envato, WooThemes,
 WordPress) there is inconsistency between slugs and collisions are
 possible, as you described. The file path is seems ideal, in my opinion.
 That is what WooThemes is using. But the / and . in the path are
 considered special characters which brings forward the issue at hand.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35032#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list