[wp-trac] [WordPress Trac] #11384: rewrite->flush() needlessly deletes the rewrite_rules option

[WordPress Trac]

#11384: rewrite->flush() needlessly deletes the rewrite_rules option
-------------------------------------------------+-------------------------
 Reporter:  Denis-de-Bernardy                    |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.5
Component:  Rewrite Rules                        |     Version:  2.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:
  tests                                          |  performance
-------------------------------------------------+-------------------------
Changes (by DrewAPicture):

 * keywords:  has-patch needs-testing => has-patch needs-testing needs-unit-
     tests
 * milestone:  Future Release => 4.5


Comment:

 Hi @brokenflipside, thanks for the refresh! Let's also add a changelog
 entry to the DocBlock for the new parameter while we're at it. More on
 changelogs in the [https://make.wordpress.org/core/handbook/best-practices
 /inline-documentation-standards/php/#since-section-changelogs core
 contributor handbook].

 Replying to [comment:7 brokenflipside]:
 > I have refreshed the patch but can't determine how to test it properly.
 :(

 A good place to start would be phpunit/tests/rewrite.php. I'd suggest
 taking a look at how some of the other methods are being tested.

 For example, start by declaring the `$wp_rewrite` global in order to
 access running the method, then perhaps test the existence of the option
 before and after the method is run.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/11384#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform