[wp-trac] [WordPress Trac] #34995: WP_Widget::widget not called

[WordPress Trac]

#34995: WP_Widget::widget not called
------------------------------------------+-----------------------
 Reporter:  btwatts                       |       Owner:
     Type:  defect (bug)                  |      Status:  reopened
 Priority:  normal                        |   Milestone:  4.4.1
Component:  Widgets                       |     Version:  4.4
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:
------------------------------------------+-----------------------
Changes (by SergeyBiryukov):

 * keywords:   => needs-patch needs-unit-tests
 * status:  closed => reopened
 * resolution:  invalid =>
 * milestone:   => 4.4.1


Comment:

 I was able to confirm the regression.

 [34465] made the `$index` argument of `dynamic_sidebar()` case-sensitive,
 because it no longer runs through `sanitize_title()`.

 The unit test added in that changeset doesn't make much sense to me,
 because it doesn't seem to test the reported issue with using special
 characters in sidebar ID. It does not even use the sidebar it registers.
 Instead, it relies on the assumption that the current default theme does
 not register a sidebar named `'Sidebar 1'`, and verifies that
 `dynamic_sidebar( 'Sidebar 1' )` does not display the sidebar registered
 with `'id' => 'sidebar-1'`. This might be a related issue, but it's not
 what was reported in #23423.

 Is there a reason to use special characters in sidebar IDs? Perhaps
 [34465] should be reverted, with #23423 closed as invalid, or pushed to a
 future release pending a proper fix.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34995#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform