[wp-trac] [WordPress Trac] #34946: new comment redirects break anchors in Safari

[WordPress Trac]

#34946: new comment redirects break anchors in Safari
---------------------------+--------------------
 Reporter:  chuckmoulton   |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.4.1
Component:  Comments       |     Version:  4.4
 Severity:  normal         |  Resolution:
 Keywords:  needs-testing  |     Focuses:
---------------------------+--------------------
Changes (by boonebgorges):

 * keywords:   => needs-testing
 * milestone:  Awaiting Review => 4.4.1


Comment:

 Thanks, @chuckmoulton. These details are very helpful.

 There are two things going on here. First, there is a regression in 4.4
 that causes `get_comment_link()` to use the 'cpage=1' query var (or
 'comment-page-1', when pretty permalinks are enabled) when comment
 pagination is disabled. This should absolutely be fixed. Could you please
 test [attachment:34946.diff] to be sure that it's resolving the problem as
 you see it?

 The other problem is a broader one. If the canonical comment-page-1
 resolution is causing problems, then we should try to avoid using comment-
 page-1 in permalinks when possible, even when comment pagination is
 enabled. When the newest comments are shown first, we cannot eliminate
 comment-page-1; it's a critical piece of the URL. But when *oldest*
 comments are shown on the first page, it should be possible to eliminate
 comment-page-1. I tried doing this in 4.4, but ran into some related
 issues. Maybe it's something to try again in 4.5.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34946#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform