[wp-trac] [WordPress Trac] #33741: Remove references to my-hacks.php and the hack_file option

[WordPress Trac]

#33741: Remove references to my-hacks.php and the hack_file option
--------------------------+-----------------------
 Reporter:  bobbingwide   |       Owner:  jorbin
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:
Component:  Plugins       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------
Changes (by bobbingwide):

 * status:  closed => reopened
 * resolution:  wontfix =>


Comment:

 After due consideration I have re-opened this ticket. If we cannot finally
 remove code that's been deprecated for 6 years then what chance have we
 dropping support for PHP 5.2.

 The first patch ( 33741.patch ) simply removes the references to my-hacks
 and hack_file.
 It finally implements what it was set out to do.

 The second patch ( 33741.2.diff ) which implements "If an option is going
 to be removed, it needs to be added to $unusedoptions in schema.php" is,
 IMHO, the flawed logic that could lead to a site being unintentionally
 broken.

 So, as stated before. Don't add hack_file into $unusedoptions.
 One day, perhaps when 5.2 support is dropped, the same argument can be
 applied to all the other "unused options". They're only unused as far as
 WordPress core is concerned.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33741#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform