[wp-trac] [WordPress Trac] #33414: Add pending count to HTML title on pending comments page

WordPress Trac noreply at wordpress.org
Sun Aug 30 02:18:20 UTC 2015


#33414: Add pending count to HTML title on pending comments page
---------------------------+-----------------------------------------
 Reporter:  peterwilsoncc  |       Owner:  wonderboymusic
     Type:  enhancement    |      Status:  assigned
 Priority:  low            |   Milestone:  4.4
Component:  Comments       |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  javascript, administration
---------------------------+-----------------------------------------

Comment (by wonderboymusic):

 In [changeset:"33806"]:
 {{{
 #!CommitTicketReference repository="" revision="33806"
 `get_comment_count()` currently increments `awaiting_moderation` when
 comments are in the trash. This occurs because `case 0:` will match any
 value passed to `switch` that is a string that isn't specified in the list
 of cases. This is terrifying.

 * Cases for `0` and `1` should be `'1'` and `'0'`
 * Add unit tests for `get_comment_count()`. Currently, there are none.

 See #33414.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33414#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list