[wp-trac] [WordPress Trac] #33561: get_transient() will always return the value of a broken transient

[WordPress Trac]

#33561: get_transient() will always return the value of a broken transient
----------------------------------------+------------------------------
 Reporter:  deconf                      |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Options, Meta APIs          |     Version:  4.3
 Severity:  normal                      |  Resolution:
 Keywords:  needs-unit-tests has-patch  |     Focuses:
----------------------------------------+------------------------------

Comment (by Otto42):

 We reported this bug to the plugin author and explained why using
 delete_transient() is better all around.

 However, what's the reasoning behind the original change in the first
 place? Simply to avoid an extra couple DB queries? I mean, I get that, but
 does it fix some other deeper bug I'm not seeing?

 Seems like a side-effect behavior change was made. It's entirely possible
 that some other plugin code relied on that side-effect without necessarily
 knowing it as well.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33561#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform