[wp-trac] [WordPress Trac] #16956: Comments Being Pulled from Non-Existent Post Types

WordPress Trac noreply at wordpress.org
Thu Aug 27 13:09:37 UTC 2015


#16956: Comments Being Pulled from Non-Existent Post Types
-------------------------------------------------+-------------------------
 Reporter:  sterlo                               |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  Posts, Post Types                    |  Release
 Severity:  normal                               |     Version:  3.1
 Keywords:  has-patch 2nd-opinion needs-unit-    |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------

Comment (by boonebgorges):

 Replying to [comment:42 bobbingwide]:
 > Is this in the early 4.4 list yet?

 I'd be very glad to get this into 4.4, but I want to make sure we respond
 adequately to [comment:41 jorbin's concerns]. In particular:

 >  At a minimum, I think we should throw a doing_it_wrong with some
 instructions so that developers are less likely to accidentally escalate
 privileges here.

 I'm not sure how this would work. The problem here occurs when a CPT is no
 longer registered, which usually means that the plugin is no longer
 active. So we can't throw a `_doing_it_wrong()`  here. Yet surely we don't
 want to discourage cap mapping in general. I think this is more of an
 education issue: plugins ought to have deactivation routines that clean up
 any sensitive content or privileges.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16956#comment:43>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list