[wp-trac] [WordPress Trac] #33475: Ensure timestamp is integer when scheduling single events

WordPress Trac noreply at wordpress.org
Sat Aug 22 04:21:08 UTC 2015


#33475: Ensure timestamp is integer when scheduling single events
---------------------------+------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.4
Component:  Cron API       |     Version:  2.1
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------

Comment (by dd32):

 @utkarshpatel for [attachment:33475.patch] I'd probably have kept the two
 checks distinct from each other (valid timestamps; and already scheduled)
 for the simple desire of readability (Also, please always add a comment
 after you upload a patch, Trac doesn't send out notifications when you
 only upload a patch)

 I don't really see a huge benefit for a `_doing_it_wrong()` here,
 developers will find out that their events are not running pretty quickly
 while testing (I would hope), this just prevents the cron array filling
 with things that won't ever be executed.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33475#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list