[wp-trac] [WordPress Trac] #33361: "Edit Comment" metabox header styling is inconsistent with others

WordPress Trac noreply at wordpress.org
Wed Aug 19 12:24:22 UTC 2015


#33361: "Edit Comment" metabox header styling is inconsistent with others
-----------------------------+---------------------------------
 Reporter:  johnjamesjacoby  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Comments         |     Version:
 Severity:  minor            |  Resolution:
 Keywords:  has-patch        |     Focuses:  ui, administration
-----------------------------+---------------------------------

Comment (by johnjamesjacoby):

 Replying to [comment:2 rachelbaker]:
 > @johnjamesjacoby Apologies for my ignorance, but which metabox header
 and alignment are you using as a reference to match?  I can see that the
 Edit Comment heading should be an `h3` but I prefer the heading and form
 labels being aligned.

 Basically, all other metaboxes. And I agree that having the `h3` (or any
 title) left-align with it's content is pleasing (and I can update the
 patch to include padding adjustments to make that happen) but I don't
 think having unique mark-up for 1 box vs. what the API would generate for
 us (if we used it in this instance) is the solution to left-alignment
 bliss.

 (Note also that the "Edit Comment" metabox content is unique in that it
 uses a `fieldset` and 'legend' combo inside a table, which is normally
 reserved for the settings API which does not use metaboxes.)

 Updated patch imminent.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33361#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list