[wp-trac] [WordPress Trac] #30261: Split all existing shared taxonomy terms on WP upgrade

[WordPress Trac]

#30261: Split all existing shared taxonomy terms on WP upgrade
-------------------------------------+---------------------------
 Reporter:  boonebgorges             |       Owner:  boonebgorges
     Type:  enhancement              |      Status:  reopened
 Priority:  high                     |   Milestone:  4.3
Component:  Taxonomy                 |     Version:
 Severity:  blocker                  |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------

Comment (by boonebgorges):

 Replying to [comment:77 Chouby]:
 > Replying to [comment:76 boonebgorges]:
 > >Before removing the invalidation suspension, can you give a few more
 details about how Polylang is being affected? I want to make sure we're
 not papering over a larger bug.
 > 1. One step in the loop creates a term A and associates it to an object
 (one of the split shared term).
 > 2. In another step, the association is removed and then I call
 `get_term()` to get the term A. The function checks for the term_count
 which is 1 instead of 0 and thus does not remove the term A when it
 should.
 > Obviously this process doesn't make sense as a whole, but inside the
 function hooked to  `split_shared_term`, I use generic functions of
 Polylang which were not specifically designed for the term split.

 Gotcha - thanks for the details. I'm OK with not suspending cache
 invalidation, but at the risk of being overly cautious, I think we should
 then reduce the batch size. In [attachment:30261.19.diff] it's 10 instead
 of 20.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30261#comment:78>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform