[wp-trac] [WordPress Trac] #30261: Split all existing shared taxonomy terms on WP upgrade

[WordPress Trac]

#30261: Split all existing shared taxonomy terms on WP upgrade
-------------------------------------+---------------------------
 Reporter:  boonebgorges             |       Owner:  boonebgorges
     Type:  enhancement              |      Status:  reopened
 Priority:  high                     |   Milestone:  4.3
Component:  Taxonomy                 |     Version:
 Severity:  blocker                  |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------

Comment (by Chouby):

 Replying to [comment:49 pento]:
 > [attachment:30261.11.diff] adds `GET_LOCK()` / `RELEASE_LOCK()` calls to
 `_wp_batch_split_terms()` in [attachment:30261.9.diff], so that only one
 process is running the routine at a time.
 >
 > I'm not especially excited about adding the HyperDB-specific code to
 core, though.
 I attempted to test your patch and the process seems to be indefinitely
 rescheduled. Thus the terms never got split.

 I am not competent enough in SQL but I wonder if calls to `GET_LOCK()` /
 `RELEASE_LOCK()` would block plugins to call `_split_shared_term()` from
 the `split_shared_term` hook.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30261#comment:53>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform