[wp-trac] [WordPress Trac] #33277: Misleading comment for wp_get_attachment_link function

WordPress Trac noreply at wordpress.org
Thu Aug 6 17:57:42 UTC 2015


#33277: Misleading comment for wp_get_attachment_link function
---------------------------------+-----------------------------
 Reporter:  several27            |       Owner:
     Type:  defect (bug)         |      Status:  new
 Priority:  normal               |   Milestone:  Future Release
Component:  Media                |     Version:  4.2.3
 Severity:  normal               |  Resolution:
 Keywords:  has-patch 4.4-early  |     Focuses:  docs
---------------------------------+-----------------------------

Comment (by MikeHansenMe):

 Just dug into this a bit and it looks like it has never supported a post
 object. The code was introduced in
 https://github.com/WordPress/WordPress/commit/0456afb16d10ad4ccc0d1a5a9b979f35ce7135e0
 it looks like the previous function(get_the_attachment_link) that was
 deprecated also forced int. So is this just a problem with the function
 doc implying it can be a post object?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33277#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list