[wp-trac] [WordPress Trac] #33258: Shift+Clicking on Widgets does not open the widgets panel in 4.3-RC

[WordPress Trac]

#33258: Shift+Clicking on Widgets does not open the widgets panel in 4.3-RC
--------------------------+---------------------------------------------
 Reporter:  obox          |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  4.3
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui, javascript, administration
--------------------------+---------------------------------------------

Comment (by westonruter):

 @afercia: I tracked down the issue with `focusable`. It turns out to have
 been introduced in [33069], specifically right here:

 {{{#!css
 .wp-full-overlay.section-open #customize-controls .wp-full-overlay-
 sidebar-content {
         visibility: hidden; /* <== this causes the focusable failure */
         overflow-y: hidden;
 }
 }}}

 The reason why this causes the `:focusable` selector to fail is that
 focusable function is defined to return `false` if any of the selected
 element's parents have `visibility: hidden`: https://github.com/jquery
 /jquery-
 ui/blob/cd6c751b88313ac1fa2e0fb46d7668ca6ce0f4b1/ui/core.js#L201-L209

 If I comment-out the `visibility: hidden;` property, then the `focus()`
 call again works as expected.

 @afercia: It seems very strange that a parent element `#customize-
 controls` for the customize controls should be getting `visibility:
 hidden`. I'm not even sure why anything in the Customizer pane is visible
 since it has an ancestor element that hidden.

 @celloexpressions: Why was this needed for accessibility?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33258#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform