[wp-trac] [WordPress Trac] #24054: (get_)comment_class() should include a is_user_member_of_blog() class

WordPress Trac noreply at wordpress.org
Mon Apr 20 03:20:08 UTC 2015


#24054: (get_)comment_class() should include a is_user_member_of_blog() class
-----------------------------------+-------------------------
 Reporter:  Viper007Bond           |       Owner:  jeremyfelt
     Type:  enhancement            |      Status:  reopened
 Priority:  normal                 |   Milestone:  4.2
Component:  Comments               |     Version:  3.5.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  multisite
-----------------------------------+-------------------------
Changes (by nacin):

 * keywords:  has-patch => has-patch 2nd-opinion
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I just noticed this. Here are the current class names: `byuser`,
 `bypostauthor`, and now `comment-author-is-site-member`. Finally, there's
 `comment-author-$login`, which means this could ''hypothetically'' clash
 with `comment-author`. Taken together, we should probably tweak this. I
 wouldn't mind something like `bysiteuser` — it's ugly, but at least it is
 consistent.

 I'm not actually sure we should have this. `byuser` seems enough; a theme
 probably doesn't need to make a network vs site call all that often. Is it
 even a theme's call to make? Isn't this better for the comment class
 filter, and probably to actually hide byuser for non-site users? (Take for
 example a university where all faculty, staff, and students have an
 account; the president's blog would probably only have his staff show up
 as a user.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24054#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list