[wp-trac] [WordPress Trac] #31964: Use a replaceable function for the beforeupload handler with shiny updates

WordPress Trac noreply at wordpress.org
Wed Apr 15 14:52:53 UTC 2015


#31964: Use a replaceable function for the beforeupload handler with shiny updates
-----------------------------+---------------------------------------------
 Reporter:  DavidAnderson    |       Owner:  jorbin
     Type:  enhancement      |      Status:  closed
 Priority:  low              |   Milestone:  4.2
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:  fixed
 Keywords:  has-patch        |     Focuses:  ui, javascript, administration
  shiny-updates              |
-----------------------------+---------------------------------------------
Changes (by jorbin):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 I would absolutely use on and off instead of duck punching
 wp.updates.beforeunload.

 I haven't tested adding js directly to the footer since that isn't the
 correct way to add javascript.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31964#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list