[wp-trac] [WordPress Trac] #31964: Use a replaceable function for the beforeupload handler with shiny updates

[WordPress Trac]

#31964: Use a replaceable function for the beforeupload handler with shiny updates
-----------------------------+---------------------------------------------
 Reporter:  DavidAnderson    |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  low              |   Milestone:  4.2
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  ui, javascript, administration
  shiny-updates              |
-----------------------------+---------------------------------------------

Comment (by jorbin):

 beforeunload is a browser event, it doesn't need to be namespaced.

 I don't think we need the 'wp-plugin-shinyupdates-loaded' event, at least
 not where it is since if you set a updates.js as a dependency in
 enqueue_script updates.js will be loaded first.  The majority of events
 are bound to document.ready which won't have taken place yet either.

 I'm cleaning up the rest of the patch (the deanonymyzing of the
 beforeunload function) and will commit that.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31964#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform