[wp-trac] [WordPress Trac] #31675: register_sidebar() without `id` parameter should be _doing_it_wrong()

WordPress Trac noreply at wordpress.org
Sat Apr 11 21:33:17 UTC 2015


#31675: register_sidebar() without `id` parameter should be _doing_it_wrong()
------------------------------+--------------------------
 Reporter:  markjaquith       |       Owner:  markjaquith
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:  4.2
Component:  Widgets           |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------------
Changes (by markjaquith):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"32110"]:
 {{{
 #!CommitTicketReference repository="" revision="32110"
 Tell developers how to correctly silence `register_sidebar()` notices.

 * If we just tell them they they should set an `id` parameter, they might
 set an arbitrary one on an existing (i.e. not in-development) theme,
 causing widgets to be lost.
 * This way, we tell them to set it to the auto-generated `id` that the
 sidebar already has.
 * Widget content is not lost, and now their sidebar has a concrete handle.

 fixes #31675
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31675#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list