[wp-trac] [WordPress Trac] #31921: String not i18n and produces error

[WordPress Trac]

#31921: String not i18n and produces error
--------------------------+--------------------
 Reporter:  dimadin       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  low           |   Milestone:  4.2
Component:  I18N          |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  i18n-change   |     Focuses:
--------------------------+--------------------
Changes (by netweb):

 * keywords:   => i18n-change
 * priority:  normal => low
 * milestone:  Awaiting Review => 4.2


Comment:

 Similar to another i18n ticket about to be created I think `Response`
 should not be capitalised:

 {{{
 #!diff
 Index: src/wp-includes/theme-compat/comments.php
 ===================================================================
 --- src/wp-includes/theme-compat/comments.php   (revision 32067)
 +++ src/wp-includes/theme-compat/comments.php   (working copy)
 @@ -26,9 +26,9 @@
         <h3 id="comments">
                 <?php
                         if ( 1 == get_comments_number() ) {
 -                               printf( 'One Response to %2$s',  '“'
 . get_the_title() . '”' );
 +                               printf( __( 'One response to %s' ),
 '“' . get_the_title() . '”' );
                         } else {
 -                               printf( _n( '%1$s Response to %2$s', '%1$s
 Responses to %2$s', get_comments_number() ),
 +                               printf( _n( '%1$s response to %2$s', '%1$s
 responses to %2$s', get_comments_number() ),
                                         number_format_i18n(
 get_comments_number() ),  '“' . get_the_title() . '”' );
                         }
                 ?>

 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31921#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform