[wp-trac] [WordPress Trac] #31405: upgrade.php fails with mixed HTTPS (SSL) and simple HTTP sites

[WordPress Trac]

#31405: upgrade.php fails with mixed HTTPS (SSL) and simple HTTP sites
-----------------------------+------------------------------
 Reporter:  intersol         |       Owner:
     Type:  defect (bug)     |      Status:  assigned
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  3.0
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:  multisite
-----------------------------+------------------------------
Changes (by jeremyfelt):

 * keywords:  dev-feedback has-patch =>
 * version:  trunk => 3.0


Comment:

 I'm not entirely sure that this should be treated as a bug. Though from
 experience, it can be pretty annoying.* :)

 During the upgrade loop, WordPress looks for the site's stored `site_url`.
 It then uses `is_ssl()` via `set_url_scheme()` to determine if the URL
 should be accessed via HTTPS. `is_ssl()` determines this based on the
 current page load only, not the page load that would occur if you had
 requested the site to be upgraded on its own.

 `set_url_scheme` is available as a filter here, which would allow you to
 make the manual decision per domain to use HTTP for an upgrade URL even if
 the current page load is HTTPS. The `admin_url` and `site_url` filters
 could be used as well.

 For this to be handled at the core level, we would probably need to
 introduce an option separate from `site_url` that tracked whether a site
 supported HTTPS. This seems like an outlier scenario, though there are
 some other tickets floating around with similar issues.

 *''I manage this through a custom admin interface while waiting for
 pending cert approvals.''

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31405#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform