[wp-trac] [WordPress Trac] #31769: Prevent navigating away while plugins are updating via shiny updates

[WordPress Trac]

#31769: Prevent navigating away while plugins are updating via shiny updates
-------------------------------------+-------------------------------------
 Reporter:  johnbillion              |       Owner:  johnbillion
     Type:  enhancement              |      Status:  reviewing
 Priority:  normal                   |   Milestone:  4.2
Component:  Upgrade/Install          |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  dev-feedback needs-      |     Focuses:  javascript,
  testing 4.2-strings has-patch      |  administration
  needs-refresh                      |
-------------------------------------+-------------------------------------

Comment (by adamsilverstein):

 In [attachment:31769.3.diff] clear updateLock, recheck queue and possible
 clear onbeforeunload in always callback, which happens after success or
 failure.

 Resolves an issue where onbeforeunload would not be cleared when updates
 fail.

 Could use some additional testing: test with failures, test in IE.

 I noticed one JS issue updating, i reverted to an old version of Jetpack
 then updated it, the slug in the response didn’t match the data-slug
 attribute looked for on L 234: {{ var $pluginRow = $( '[data-slug="' +
 response.slug + '"]' ).first(); }} - possibly because the slug changed? we
 should ensure the slug always matches here, or at least check and not fail
 if it changed, this failure broke the rest of my updates (I had queued
 multiple).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31769#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform