[wp-trac] [WordPress Trac] #24148: Add aria-labelledby attributes to comment form

WordPress Trac noreply at wordpress.org
Thu Sep 18 08:15:57 UTC 2014


#24148: Add aria-labelledby attributes to comment form
-------------------------+------------------------------
 Reporter:  joedolson    |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Comments     |     Version:  3.5
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  accessibility
-------------------------+------------------------------

Comment (by GaryJ):

 How come the comment label gets an `id` attribute that is then referenced
 in the `aria-labelledby` attribute for the comment field (good), but the
 email label gets an extra wrapping `span` with an `id` and **that's**
 referenced in the `aria-labelledby` attribute in the email field instead?
 Why the inconsistent approach (direct ID versus wrapping span with ID)?
 The ''required'' span is already completely inside the label, and the
 label is wholly inside the new extra span. The latest patch is:

 {{{
 <span id="email-label"><label ...>...</label></span>
 }}}

 Could it not be:

 {{{
 <label ... id="email-label">...</label>
 }}}
 ?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24148#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list