[wp-trac] [WordPress Trac] #29490: Twenty Fourteen: move the background-may-not-be-visible help text from the Colors section to the Background Color control in the Customizer

WordPress Trac noreply at wordpress.org
Mon Sep 8 02:08:01 UTC 2014


#29490: Twenty Fourteen: move the background-may-not-be-visible help text from the
Colors section to the Background Color control in the Customizer
----------------------------------------------------+------------------
 Reporter:  celloexpressions                        |       Owner:
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  4.1
Component:  Bundled Theme                           |     Version:  4.0
 Severity:  normal                                  |  Resolution:
 Keywords:  good-first-bug has-patch needs-testing  |     Focuses:
----------------------------------------------------+------------------
Changes (by celloexpressions):

 * milestone:  Future Release => 4.1


Comment:

 Patch looks good, Jon! Looks like you caught the issue with the
 indentation based on the patch descriptions, but it looks like
 [attachment:29490.3.diff] is identical to .2?

 @jb510 worked on this at the WCLA contributor day today; @obenland thought
 that it was worth keeping the descriptions on the sections when they're
 not supported on controls, which would be for anyone using Twenty Fourteen
 1.3+ with WordPress 3.9-, hence the conditional check. We might want to
 add something to that effect in an inline comment.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29490#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list