[wp-trac] [WordPress Trac] #23834: Menus: add visual Indicator for menu items with children

[WordPress Trac]

#23834: Menus: add visual Indicator for menu items with children
-----------------------------------+---------------------
 Reporter:  downstairsdev          |       Owner:  helen
     Type:  enhancement            |      Status:  closed
 Priority:  normal                 |   Milestone:  3.7
Component:  Menus                  |     Version:  3.6
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+---------------------
Changes (by McGuive7):

 * keywords:  has-patch => has-patch 2nd-opinion


Comment:

 I realized this is closed, but I'd love to know what factored into the
 decision to split this out into two classes, one for wp_nav_menu() and one
 for wp_page_menu(). This requires writing including, at minimum, two CSS
 selectors when writing rules for parent pages. Can I ask, why not just go
 with a global .has-children class? Semantically, the two class method
 doesn't really add any value, as there are already other classes
 indicating the type of item being output. I may be missing something, but
 it seems to me that the single class method is more in line with modular
 CSS practices, and if nothing else, just eliminates the need to include
 two selectors when styling. Can someone clarify, and/or is this worth re-
 opening for future improvements?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23834#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform