[wp-trac] [WordPress Trac] #29980: Twenty Fifteen: hidden header text control doesn't update with color scheme

[WordPress Trac]

#29980: Twenty Fifteen: hidden header text control doesn't update with color scheme
---------------------------+--------------------
 Reporter:  cainm          |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.1
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:
---------------------------+--------------------

Comment (by cainm):

 Replying to [comment:12 downstairsdev]:
 > Edit: Easier said than done. Looks like without that conditional anytime
 the color scheme is changed the header will display, even if it is
 supposed to be hidden. Haven't exactly been able to trace down why that
 happens.

 Yeah, I found out the same thing when working on this originally. Core
 treats `display_header_text` as an additional control on the
 `header_textcolor` setting - not on a separate setting - and as thus, when
 the Header Text is hidden,`header_textcolor` is set to 'blank', and then
 the 'blank' value is used in most Custom Header text color functionality
 throughout core and themes (including
 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/theme.php#L1030 display_header_text()]).

 Skipping the conditional in this file overwrites the 'blank' value, and
 tricks `display_header_text()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29980#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform