[wp-trac] [WordPress Trac] #12668: Better support for custom comment types

[WordPress Trac]

#12668: Better support for custom comment types
----------------------------------------+------------------------------
 Reporter:  ptahdunbar                  |       Owner:  ptahdunbar
     Type:  enhancement                 |      Status:  reopened
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Comments                    |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+------------------------------

Comment (by dancameron):

 Sorry guys...I think I know why there's a bit of confusion since I removed
 a very important check for an explicit 'comment' argument (now on line
 number 458).

 [https://core.trac.wordpress.org/attachment/ticket/12668/12668-comments-
 query.4.patch 12668-comments-query.4.patch] brings back the contribution
 that [comment:63 mordauk] had already made in
 [https://core.trac.wordpress.org/attachment/ticket/12668/12668-comments-
 query.patch 12668-comments-query.patch] with some formatting differences
 and the sanitization callback of `esc_sql`.

 Also, I mentioned that I would love to do the Unit Tests but I might not
 get around to it before WCSF so please do not wait for me.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/12668#comment:64>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform