[wp-trac] [WordPress Trac] #29908: date_query inclusive logic still not quite right

WordPress Trac noreply at wordpress.org
Mon Oct 13 12:27:13 UTC 2014


#29908: date_query inclusive logic still not quite right
-------------------------------------+---------------------------
 Reporter:  magicroundabout          |       Owner:  boonebgorges
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.1
Component:  Query                    |     Version:  4.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------

Comment (by magicroundabout):

 Why don't we `date_parse()`?

 The only issue that I can see with using `date_parse()` is that it would
 be breaking if, say, someone had sent a date AND time string in `before`
 or `after` (e.g. `'before' => '2013-01-13 12:00:00')`. Arguably, the
 documentation doesn't say that that will work. It says "'''Date''' to
 retrieve posts after. Accepts `strtotime()`-compatible string"

 I'm happy to code up a new patch and/or test Boone's work.

 Is there some info somewhere on the best way to create and test out
 patches?  Would love to contribute (finally!). It's just not something
 I've done before.  I'm an experienced dev with multiple local and remote
 test installs, so happy to talk as technical as you like, but just not
 worked with trac and patches much.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29908#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list