[wp-trac] [WordPress Trac] #29827: Leftover taxonomies break later tests

[WordPress Trac]

#29827: Leftover taxonomies break later tests
-----------------------------------+---------------------------
 Reporter:  boonebgorges           |       Owner:  boonebgorges
     Type:  defect (bug)           |      Status:  accepted
 Priority:  normal                 |   Milestone:  4.1
Component:  Build/Test Tools       |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |     Focuses:
-----------------------------------+---------------------------
Changes (by boonebgorges):

 * keywords:  2nd-opinion => 2nd-opinion has-patch


Comment:

 [attachment:29827.4.patch] is a much simpler fix. Basically, only
 wipe+reset post types and taxonomies if running `phpunit` from the WP
 root. Other projects that use `WP_UnitTestCase` or whatever won't have
 `WP_RUN_CORE_TESTS` enabled by default, though they could flip it on if
 they wished. (I chose a generic constant name because this could be useful
 elsewhere, but it could be made more specific.)

 So, the question is really whether it's more important (a) to enforce
 separation of tests for anyone using our test tools (in which case,
 wontfix), or (b) not to break every CI build that depends on WP test tools
 (in which case, 4.patch).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29827#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform