[wp-trac] [WordPress Trac] #7092: Should support separate setting for limiting comments feed

WordPress Trac noreply at wordpress.org
Thu Oct 9 15:29:56 UTC 2014


#7092: Should support separate setting for limiting comments feed
---------------------------+------------------------
 Reporter:  redsweater     |       Owner:
     Type:  enhancement    |      Status:  closed
 Priority:  normal         |   Milestone:
Component:  Feeds          |     Version:  2.9
 Severity:  normal         |  Resolution:  duplicate
 Keywords:  needs-refresh  |     Focuses:
---------------------------+------------------------

Comment (by DrewAPicture):

 Replying to [comment:28 redsweater]:
 > Replying to [comment:26 chriscct7]:
 > > This was fixed in #9635 and further revised in #9886
 >
 > I don't think either of the cited tickets are suitable duplicates of
 this one. Trunk WordPress still doesn't support the feature requested by
 this ticket: separate user control over the number of items in the
 comments feed.

 It's effectively a duplicate of #9635 because the spirit of the ticket was
 met by introducing a filter to allow modifying the comment feed limits,
 [https://developer.wordpress.org/reference/hooks/comment_feed_limits/
 comment_feed_limits].

 > nacin's earlier patch made the point of establishing a new setting for
 "comments_per_rss", and added UI to the reading options in the settings
 admin UI. Neither of those goals is achieved (so far as i can tell) by the
 tickets cited as duplicates.

 An option isn't going to be added per the "decisions not options" mantra.
 The filter allows plugins to modify the value without adding an additional
 option, and either of the two
 [https://developer.wordpress.org/reference/hooks/comment_feed_limits/#comment-80
 examples] I just posted on the `comment_feed_limits` hook reference should
 suffice.

 If you want an option-based solution, check out @hakre's plugin
 [attachment:hakre-commentsfeedlength-7092.php] attached above.

 > If it's going to be closed, it should be closed as invalid instead of
 incorrectly stating that other tickets have rendered it moot.

 I'm reclosing it as a duplicate.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/7092#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list