[wp-trac] [WordPress Trac] #29886: WP_HTTP::make_absolute_url() treats schemeless URLs as relative

[WordPress Trac]

#29886: WP_HTTP::make_absolute_url() treats schemeless URLs as relative
--------------------------+---------------------
 Reporter:  dd32          |       Owner:  dd32
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.1
Component:  HTTP API      |     Version:  trunk
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |     Focuses:
--------------------------+---------------------

Comment (by dd32):

 In [changeset:"29864"]:
 {{{
 #!CommitTicketReference repository="" revision="29864"
 Add some unit tests for WP_HTTP::parse_url() to cover the <PHP 5.4.7
 compatibility alterations.

 These unit tests cover the expected vehaviour of certain combinations of
 URL's, but makes no attempt to test invalid URL structures, as PHP's
 behavious for invalid URL's is undefined (Some will be treated as paths,
 others fail, and it varies between PHP 5.4.7+ and <5.4.7).
 This change also makes WP_HTTP::parse_url() protected in order to allow
 unit testing.
 See #28001, #29886
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29886#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform