[wp-trac] [WordPress Trac] #16433: Extend function to optionally include commenter name in comment_reply_link

WordPress Trac noreply at wordpress.org
Thu Oct 2 13:20:47 UTC 2014


#16433: Extend function to optionally include commenter name in comment_reply_link
-------------------------+-----------------------------
 Reporter:  Elpie        |       Owner:  merty
     Type:  enhancement  |      Status:  accepted
 Priority:  low          |   Milestone:  Future Release
Component:  Comments     |     Version:  3.0.4
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  accessibility
-------------------------+-----------------------------

Comment (by GaryJ):

 Replying to [comment:16 joedolson]:
 > Maybe...two considerations there:
 >
 > 1) that would potentially lead to translation challenges with the
 connecting term

 Agreed. "Reply" and "Reply to ..." may not have the same first word in
 non-English languages.

 > 2) if the theme passes a non-word value, the label could lose meaning.

 Disagree. Theme authors can already filter the whole of the comment reply
 link anyway (or the comment callback), and I guess they could also filter
 your new aria-label string on `gettext` too if they only want to change
 the "Reply to" bit. So adding it as a default would be more about
 providing a consistent customisation interface for developers than
 anything else, allowing them to perhaps reply to comment number (which
 would be unique), rather than username (which wouldn't, when there are
 comments by the same author name).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16433#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list