[wp-trac] [WordPress Trac] #15928: wp_get_attachment_url does not check for HTTPS

[WordPress Trac]

#15928: wp_get_attachment_url does not check for HTTPS
-----------------------------------+-----------------------------
 Reporter:  atetlaw                |       Owner:  boonebgorges
     Type:  defect (bug)           |      Status:  accepted
 Priority:  normal                 |   Milestone:  Future Release
Component:  Permalinks             |     Version:  3.0.3
 Severity:  normal                 |  Resolution:
 Keywords:  needs-patch 4.2-early  |     Focuses:
-----------------------------------+-----------------------------

Comment (by joemcgill):

 Replying to [comment:91 boonebgorges]:

 New patch [attachment: 15928.12.patch] adds a third test to make sure
 we're not forcing urls into an https scheme when the function is called
 from a different host using SSL (e.g., the case of a site running
 admin/front over different hosts). I also modified the logic of
 `test_wp_get_attachment_with_https_off()` and
 `test_wp_get_attachment_url_with_https_on_diff_host()` to test that the
 scheme of the url returned matches the scheme coming out of the uploads
 directory, which isn't necessarily http.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/15928#comment:92>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform