[wp-trac] [WordPress Trac] #30497: Impossible to change upgrader skin when Language_Pack_Upgrader is instanciated via Language_Pack_Upgrader::async_upgrade()

[WordPress Trac]

#30497: Impossible to change upgrader skin when Language_Pack_Upgrader is
instanciated via Language_Pack_Upgrader::async_upgrade()
-----------------------------+-----------------------------
 Reporter:  rodrigosprimo    |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:  4.0
 Severity:  normal           |   Keywords:
  Focuses:                   |
-----------------------------+-----------------------------
 WP-CLI uses its own upgrader skin class (WP_CLI\UpgraderSkin) to remove
 HTML from the strings that are displayed to the users.

 But it is not possible to change the upgrader skin when
 Language_Pack_Upgrader is instanciated via
 Language_Pack_Upgrader::async_upgrade() resulting in the problem described
 in the issue below:

 https://github.com/wp-cli/wp-cli/issues/1501

 The attached patch implements a possible solution for this adding a filter
 to change the upgrader skin class name. I'm not sure if this is the best
 way to fix this or if we should refactor this method and the way it is
 called to add the upgrader skin class as a parameter.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30497>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform