[wp-trac] [WordPress Trac] #28319: Add hook to WP_Error for logging and report purposes

WordPress Trac noreply at wordpress.org
Mon Nov 24 03:28:05 UTC 2014


#28319: Add hook to WP_Error for logging and report purposes
-----------------------------------+-----------------------------
 Reporter:  ebinnion               |       Owner:  johnbillion
     Type:  enhancement            |      Status:  reopened
 Priority:  normal                 |   Milestone:  Future Release
Component:  General                |     Version:  4.0
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |     Focuses:
-----------------------------------+-----------------------------

Comment (by dd32):

 > In this specific case get_terms_to_edit() returns a WP_Error for a
 taxonomy that Schrödinger exists, it's then used as a string causing a
 fatal in the admin.

 Then WordPress needs to add a is_wp_check() to the result of
 get_terms_to_edit() and it's friends before attempting to use it as a
 string then. I've created #30472 for that.

 I'm not against this patch, but I do wonder if it'll actually be as useful
 as expected, or if it's just a hack to fix that one situation.
 A logging interface (PSR-3 style) seems to be a far better option IMHO.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28319#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list