[wp-trac] [WordPress Trac] #28361: Twenty Ten, Eleven and Twelve: PHP notices due to undefined vars in attachment template

WordPress Trac noreply at wordpress.org
Mon May 26 20:26:33 UTC 2014


#28361: Twenty Ten, Eleven and Twelve: PHP notices due to undefined vars in
attachment template
------------------------------+--------------------
 Reporter:  nabil_kadimi      |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.0
Component:  Bundled Theme     |     Version:  trunk
 Severity:  minor             |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch => has-patch commit


Comment:

 I guess we should still avoid the notice here.

 [attachment:28361.2.patch] moves `$k++` to the `if ( count( $attachments )
 > 1 )` branch and also makes `adjacent_image_link()` more consistent with
 `get_adjacent_post_link()`, which has a check for a valid post object:
 [source:tags/3.9.1/src/wp-includes/link-template.php#L1807].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28361#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list