[wp-trac] [WordPress Trac] #28356: wp_widget_rss_output() cleanup
WordPress Trac
noreply at wordpress.org
Sun May 25 11:46:51 UTC 2014
#28356: wp_widget_rss_output() cleanup
----------------------------+------------------------------
Reporter: SergeyBiryukov | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.0
Component: Widgets | Version: 3.9
Severity: normal | Keywords: has-patch commit
Focuses: |
----------------------------+------------------------------
There are some issues in `wp_widget_rss_output()`:
* `[…]` is never appended to `$summary` since [27691] (see lines
876 and 881).
* `wp_html_excerpt()` can cut a string in a middle of a word.
`wp_trim_words()` should be used instead, which would make some of the
other string manipulations here redundant.
* `$title` is escaped with `esc_attr()`, but never used as an attribute.
`esc_html()` should be used instead.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/28356>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list