[wp-trac] [WordPress Trac] #28109: Minor fix in Media Editor

WordPress Trac noreply at wordpress.org
Fri May 23 20:47:07 UTC 2014


#28109: Minor fix in Media Editor
---------------------------+------------------
 Reporter:  hardeepasrani  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.0
Component:  Media          |     Version:  3.9
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  ui
---------------------------+------------------

Comment (by hardeepasrani):

 Looks good to me. Thanks for improving the patch :)

 Replying to [comment:5 ericlewis]:
 > Thanks for the good work here @hardeepasrani. I've cleaned up the
 implementation in attachment:28109.diff.
 >
 > Change top to exactly 84px. The `.media-frame .embed-url` text input =
 52px (26px of line-height of the text input plus 12px top and bottom
 padding plus 1px top and bottom margin) plus the padding on .embed-url =
 32px (16px top and bottom).
 >
 > Let's remove padding-top on the .embed-media-settings so the input box
 so there's not awkward extra space between the text input and the image.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28109#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list