[wp-trac] [WordPress Trac] #22075: Improving `wp_get_attachment_link`

WordPress Trac noreply at wordpress.org
Fri May 23 15:37:35 UTC 2014


#22075: Improving `wp_get_attachment_link`
--------------------------+-----------------------------
 Reporter:  webord        |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Media         |     Version:  3.4
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |     Focuses:
--------------------------+-----------------------------
Changes (by ericlewis):

 * keywords:  has-patch dev-feedback => dev-feedback


Comment:

 Sure, sounds valid.

 I'm not a fan of daisy chaining more parameters onto the function's
 signature. Perhaps we could consider moving over to an array hash while
 supporting backwards compatibility
 [https://github.com/buddypress/BuddyPress/blob/d2f485a45ef4864bbc7f56544cd9e20dcee75d6e/src
 /bp-groups/bp-groups-functions.php#L415 a la BuddyPress]?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22075#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list