[wp-trac] [WordPress Trac] #27882: Address some issues found running Scrutinizer

[WordPress Trac]

#27882: Address some issues found running Scrutinizer
----------------------------+---------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:  fixed
 Keywords:  needs-patch     |     Focuses:
----------------------------+---------------------
Changes (by wonderboymusic):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Gonna mark this as fixed after 64 healthy commits. Almost all of the
 remaining issues are related to:

 * Top-level code, global variables. There a lot of variables that get set
 in a file and are assumed by us to spill down to other places (think, the
 admin). We should get away from top-level code, but we have tons of it.
 * Parameters to functions/methods that are unused but will remain for BC.
 * Parameters to methods that only exist in subclasses to match parent
 methods' signatures.
 * All kinds of garbage in the files we include from external libraries.
 * Some actual issues we can address in other ways outside of this ticket.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27882#comment:77>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform