[wp-trac] [WordPress Trac] #27538: Widget Customizer: Persistent object cache/Transients causes certain previewed widgets to leak outside of customizer

[WordPress Trac]

#27538: Widget Customizer: Persistent object cache/Transients causes certain
previewed widgets to leak outside of customizer
--------------------------+--------------------
 Reporter:  westonruter   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  3.9
Component:  Widgets       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------

Comment (by nacin):

 I noticed an issue here. wp_suspend_cache_addition() is designed to
 prevent cache *adds*, as in put something into cache that isn't there yet
 — but not cache *sets*, as in update existing stale cache. Suspending sets
 could be a problem as then caches would get out of sync with the raw data;
 that's not the case with suspending adds.

 Transients only have a "set" method. They don't have an "add" version. We
 could block sets, but that would mean it is possible that a stale
 transient is not somehow updated. While it's probably better *in this
 case* to suspend transient sets, always suspending transient sets during
 the suspension of cache adds is likely not the blanket assumption we'd
 want to make.

 I don't entirely know what to do here. Asking others to weigh in.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27538#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform