[wp-trac] [WordPress Trac] #23862: Clean up old WP->public_query_vars and WP->private_query_vars

[WordPress Trac]

#23862: Clean up old WP->public_query_vars and WP->private_query_vars
--------------------------+-----------------------------
 Reporter:  prettyboymp   |       Owner:  nacin
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  Future Release
Component:  Query         |     Version:
 Severity:  trivial       |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------------
Changes (by nacin):

 * status:  closed => reopened
 * resolution:  fixed =>
 * milestone:  3.9 => Future Release


Comment:

 Alright, this actually broke a canonical unit test. (The noRewrite
 ?post_type=fake-cpt&p=1 one.)

 WP::parse_request() parses public query vars and then parses private query
 vars. But in between there, it discards any post types that aren't
 publicly queryable. The canonical tests leverage WP::main() directly, and
 thus private query vars have outsized influence... It's kinda tough to
 explain, and was not fun to track down.

 Anyway, as this was ostensibly for cleanup, and it clearly causes some
 side effects, I'm reverting.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23862#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform