[wp-trac] [WordPress Trac] #27292: HTML5 Captions: Apply the filter img_caption_shortcode_width

[WordPress Trac]

#27292: HTML5 Captions: Apply the filter img_caption_shortcode_width
-------------------------+----------------------
 Reporter:  jond3r       |       Owner:
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:
Component:  Media        |     Version:  trunk
 Severity:  normal       |  Resolution:  invalid
 Keywords:  has-patch    |     Focuses:
-------------------------+----------------------
Changes (by obenland):

 * status:  new => closed
 * focuses:  template =>
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 Replying to [comment:7 jond3r]:
 > Now that we are officially smashed by #26642 (that title was changed to
 'HTML5 captions', ouch!), we have to refocus this ticket to 'restore' the
 use of the {{{img_caption_shortcode_width}}} filter for the case when
 theme support has been added for HTML5 captions.

 I don't think we do. `img_caption_shortcode_width` is deliberately not
 used when the theme supports HTML5 captions. This was also mentioned in
 the commit message for r27668.

 The filter was introduced to give theme authors the ability to remove the
 added 10px, so the filter always expects `width + 10px`. Since HTML5
 captions don't have the added 10px, it would break backwards compatibility
 if we applied the filter there.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27292#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform