[wp-trac] [WordPress Trac] #28464: grunt jshint for plugins and plugin developers

WordPress Trac noreply at wordpress.org
Mon Jun 23 02:45:39 UTC 2014


#28464: grunt jshint for plugins and plugin developers
------------------------------+-----------------------------
 Reporter:  MattyRob          |       Owner:  wonderboymusic
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  4.0
Component:  Build/Test Tools  |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------------

Comment (by netweb):

 Two thoughts:

 1) This task will only run JSHint on plugins being developed in `\src\wp-
 content\plugins`
 * If a plugin developer needs, and I believe that they should, they should
 be running WordPress trunk from `/build` via the `develop.svn` repo or
 they should use `core.svn` to develop their plugin.

 * Developing plugins by loading WordPress via `\src\wp-content\plugins` of
 the `develop.svn` repo excludes RTL CSS or admin themes CSS (Midnight,
 Ocean etc) and I think we should be encouraging plugin authors to test
 their plugins for compatibility with these core features.


 2) The `jshint:plugin` task is now included by default in `grunt
 precommit` and `grunt travis:js` tasks
 * It does not cause an error running either task though a warning is
 displayed (see image below)

 * If not we should register a new task eg. `jshint:corejs` to call from
 `grunt precommit` and `grunt travis:js` so `jshint:plugin` is not
 included. eg
 [https://core.trac.wordpress.org/attachment/ticket/28464/28464.corejs.diff
 28464.corejs.diff]

 * [[Image(https://i.cloudup.com/TYF2875QEj.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28464#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list