[wp-trac] [WordPress Trac] #28575: Eliminate redundant preg_match() to improve wptexturize() performance

WordPress Trac noreply at wordpress.org
Thu Jun 19 21:54:21 UTC 2014


#28575: Eliminate redundant preg_match() to improve wptexturize() performance
-------------------------------------+-----------------------------
 Reporter:  dllh                     |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.0
Component:  Formatting               |     Version:  3.9
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  performance
-------------------------------------+-----------------------------

Comment (by miqrogroove):

 Replying to [comment:7 SergeyBiryukov]:
 > Indeed, looks like [attachment:28575.patch] would be a correct solution
 here.

 That's what I had in mind.

 > But even if it was a typo, how does [28776] corrupt HTML output? All
 texturize unit tests still pass

 I was thinking back to why I originally moved that code inside the loop.
 The replacement was matching and modifying links to image files, which is
 not what we want.  I'm not even sure I wrote unit tests for that scenario.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28575#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list