[wp-trac] [WordPress Trac] #28517: Logic error in WP_Rewrite flush_rules

[WordPress Trac]

#28517: Logic error in WP_Rewrite flush_rules
---------------------------+------------------------------
 Reporter:  numis          |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Rewrite Rules  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------------

Comment (by numis):

 The patches still stand, but the previous assessment of the flawed code
 was incorrect.  The outcome is actually worse than previously described.

 =============================================

 If $hard is true and either no filters are added, or a filter is added
 that returns true:
 {{{
 ! true  || ! true = false || false = false
 }}}
 {{{
 #!html
 <span style="color: green; font-weight: strong;" >INTENTIONAL SUCCESS -
 HARD FLUSH PERFORMED</span>
 }}}

 =============================================

 If $hard is true and a filter is added that returns false:
 {{{
 ! true || ! false = false || true = true
 }}}
 {{{
 #!html
 <span style="color: red; font-weight: strong;" >UNINTENTIONAL FAILURE -
 SOFT FLUSH PERFORMED</span>
 }}}

 =============================================

 If $hard is false and either no filters are added, or a filter is added
 that returns true:
 {{{
 ! false || ! true = true || false = true
 }}}
 {{{
 #!html
 <span style="color: red; font-weight: strong;" >UNINTENTIONAL FAILURE -
 SOFT FLUSH PERFORMED</span>
 }}}

 =============================================

 If $hard is false and a filter is added that returns false:
 {{{
 ! false || ! false = true || true = true
 }}}
 {{{
 #!html
 <span style="color: red; font-weight: strong;" >UNINTENTIONAL FAILURE -
 SOFT FLUSH PERFORMED</span>
 }}}

 =============================================

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28517#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform