[wp-trac] [WordPress Trac] #18791: Add custom post type support for Author Template functions

WordPress Trac noreply at wordpress.org
Thu Jun 5 21:53:00 UTC 2014


#18791: Add custom post type support for Author Template functions
-------------------------+-----------------------
 Reporter:  sirzooro     |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.0
Component:  Users        |     Version:  3.2.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  template
-------------------------+-----------------------

Comment (by mordauk):

 Replying to [comment:10 nacin]:
 > I think is_multi_author() should be left alone entirely.
 >
 > Not sure I see why get_posts_by_author_sql() needs to change at all,
 either. The sanitization/preparation in get_posts_by_author_sql() looks
 wrong. A unit test would catch this. (Needs unit tests.) The other
 instance of $post_type_where has similar issues.

 If not adding support for multiple post types, I think you're right in
 that get_posts_by_author_sql() doesn't need changed at all.

 I'd disagree about is_multi_author() though. For sites that use multiple
 public post types, it would be expected for is_multi_author() to properly
 detect when there are multiple authors on the site.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/18791#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list