[wp-trac] [WordPress Trac] #11330: Empty search takes you to homepage instead of empty search page

[WordPress Trac]

#11330: Empty search takes you to homepage instead of empty search page
------------------------------+-----------------------------
 Reporter:  jacobfogg         |       Owner:  wonderboymusic
     Type:  defect (bug)      |      Status:  reopened
 Priority:  low               |   Milestone:  4.0
Component:  Query             |     Version:  2.8.5
 Severity:  minor             |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:35 wonderboymusic]:
 > Prevent admin breakage for `s` in `WP_Query` after [28623].

 To clarify, `$this->is_main_query()` is true for list tables, so this was
 technically broken in [28612], not in [28623].

 Replying to [comment:38 johnbillion]:
 > It sounds like this has the potential to break in the same way for
 faceted search forms on the front end of a site.

 Yep, that's what I meant.

 [attachment:11330.5.diff] uses `$this->is_admin` and moves the check to a
 more appropriate place if we want to keep it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/11330#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform