[wp-trac] [WordPress Trac] #24380: Missing Compression Parameter in WP_Image_Editor_GD

WordPress Trac noreply at wordpress.org
Wed Jun 4 19:57:44 UTC 2014


#24380: Missing Compression Parameter in WP_Image_Editor_GD
-------------------------+-----------------------------
 Reporter:  MuViMoTV     |       Owner:  wonderboymusic
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  4.0
Component:  Media        |     Version:  3.5.1
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |     Focuses:  docs
-------------------------+-----------------------------
Changes (by DrewAPicture):

 * keywords:  has-patch => needs-patch


Comment:

 So, looking at [attachment:24380.3.patch], I've got a couple of questions:

 1. We're converting 1-100 to 0-9 ... oh except it also accepts -1? The -1
 information should be at the end so it doesn't create confusion.
 2. In the `png_compression_level` filter docs, it's mentioned that there
 are two different contexts possible, yet the filter is only evaluated one
 place in the codebase and the context isn't dynamic. So where would the
 second context enter the picture? Also, the contexts should be spelled out
 for the `$context` parameter, not in the long description area.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24380#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list