[wp-trac] [WordPress Trac] #29072: $wp_list_table->items[$plugin_file] assignments failing in 4.0Beta2

[WordPress Trac]

#29072: $wp_list_table->items[$plugin_file] assignments failing in 4.0Beta2
--------------------------+-----------------------------
 Reporter:  adiant        |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Plugins       |    Version:
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 All testing done with WordPress 4.0-beta2-20140729 with default theme
 (Twenty Fourteen) and only the plugin causing the problem activated.

 Assignments to global $wp_list_table->items[$plugin_file] are failing with
 the following Notice:  "Notice: Indirect modification of overloaded
 property WP_Plugins_List_Table::$items has no effect in...".

 This technique works properly, without any messages, in Version 3.9.1.

 This code is only executed in Site Admin for a Network Site;  I have not
 tested in Network Admin or on non-Network installs.

 This can be replicated reliably on Version 4.0-beta2-20140729 of WordPress
 with Version 3.1 of jonradio Reveal Network Activated Plugins on the
 Installed Plugins page of Site Admin for any site in a Network, when the
 plugin is Network Activated, or on a single site in a Network when the
 plugin is not Network Activated but only activated on the single site.
 The Installed Plugins Admin panel displays the errors when WP_DEBUG is
 TRUE, and the Plugins table is displayed as empty.

 Relevant code sequence (i.e. - only the most relevant statements shown):

 {{{
 global $wp_list_table;
 $wp_list_table->items = array();
 $wp_list_table->items[$plugin_file] = _get_plugin_data_markup_translate(
 $plugin_file, $plugin_data, false, true );
 uasort( $wp_list_table->items, 'jr_rnap_sort_plugins' );
 }}}

 The last two statements produce the Notice.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29072>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform