[wp-trac] [WordPress Trac] #28913: wpviews: keyboard behaviour for a selected view

WordPress Trac noreply at wordpress.org
Sat Jul 19 19:35:20 UTC 2014


#28913: wpviews: keyboard behaviour for a selected view
----------------------------------+-----------------------
 Reporter:  avryl                 |       Owner:  azaozz
     Type:  defect (bug)          |      Status:  reopened
 Priority:  normal                |   Milestone:  4.0
Component:  TinyMCE               |     Version:  3.9
 Severity:  normal                |  Resolution:
 Keywords:  has-patch needs-docs  |     Focuses:
----------------------------------+-----------------------

Comment (by DrewAPicture):

 Replying to [comment:9 avryl]:
 > Are there any guidelines for this? I don't see a page in the handbook
 for JS. Only
 > http://make.wordpress.org/core/handbook/inline-documentation-standards
 /php-documentation-standards/

 Not yet. I'm writing a post proposing we adopt the [http://usejsdoc.org/
 JSdoc 3 standard] though.

 At this point we just need a description of what it does, when it was
 introduced, and any parameters including the type and description.
 Something like:

 {{{
 #!js
 /**
  * What it does.
  *
  * @since 4.0.0
  *
  * @param {type} view Description.
 function removeView( view ) {
         // TODO: trigger an event to run a clean up function.
         // Maybe `jQuery( view ).trigger( 'remove' );`?
         editor.undoManager.transact( function() {
                 handleEnter( view );
                 editor.dom.remove( view );
         });
 }
 }}}

 The hope is to come back later and fix up what's missing (what I'm
 currently doing primarily for PHP).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28913#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list